Hi Arnd, On 14.08.2018 15:58, Arnd Bergmann wrote: > On Tue, Aug 14, 2018 at 2:45 PM Todor Tomov <todor.tomov@xxxxxxxxxx> wrote: >> >> Hi Arnd, >> >> On 14.08.2018 12:13, Arnd Bergmann wrote: >>> Multiple files in this driver fail to build because of missing >>> header inclusions: >>> >>> drivers/media/platform/qcom/camss/camss-csiphy-2ph-1-0.c: In function 'csiphy_hw_version_read': >>> drivers/media/platform/qcom/camss/camss-csiphy-2ph-1-0.c:31:18: error: implicit declaration of function 'readl_relaxed'; did you mean 'xchg_relaxed'? [-Werror=implicit-function-declaration] >>> drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c: In function 'csiphy_hw_version_read': >>> drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c:52:2: error: implicit declaration of function 'writel' [-Werror=implicit-function-declaration] >> >> Thank you for noticing this and preparing a patch. >> I build for arm64 and x86_64 with compile test enabled and I don't see these errors. Do you have a guess what is different that I don't have them? > > I try lots of randconfig builds, and only one of them hit this, so > it's surely some > header that may or may not include io.h and slab.h depending on the > configuration, > or based on some other changes in linux-next. > > Since the solution seemed obvious, I did not investigate further. > > If you want to try reproducing the problem, see the arm64 config file > at https://pastebin.com/raw/bNTPvYfZ Thank you, I was able to reproduce it. I have sent another patch which changes kcalloc to devm_kcalloc so the hunk including slab.h is not needed anymore. For the rest of the patch you can have my: Acked-by: Todor Tomov <todor.tomov@xxxxxxxxxx> -- Best regards, Todor Tomov
