Em Sat, 4 Aug 2018 14:45:10 +0200 Hans Verkuil <hverkuil@xxxxxxxxx> escreveu: > From: Hans Verkuil <hans.verkuil@xxxxxxxxx> > > There is no need to check the vb2 state in the buf_prepare > callback: it can never be wrong. > > Since VB2_BUF_STATE_PREPARED will be removed in the next patch > we'll remove this unnecessary check (and use of that state) first. > > Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> Reviewed-by: Mauro Carvalho Chehab <mchehab+samsung@xxxxxxxxxx> > --- > drivers/staging/media/davinci_vpfe/vpfe_video.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/staging/media/davinci_vpfe/vpfe_video.c b/drivers/staging/media/davinci_vpfe/vpfe_video.c > index 1269a983455e..4e3ec7fdc90d 100644 > --- a/drivers/staging/media/davinci_vpfe/vpfe_video.c > +++ b/drivers/staging/media/davinci_vpfe/vpfe_video.c > @@ -1135,10 +1135,6 @@ static int vpfe_buffer_prepare(struct vb2_buffer *vb) > > v4l2_dbg(1, debug, &vpfe_dev->v4l2_dev, "vpfe_buffer_prepare\n"); > > - if (vb->state != VB2_BUF_STATE_ACTIVE && > - vb->state != VB2_BUF_STATE_PREPARED) > - return 0; > - > /* Initialize buffer */ > vb2_set_plane_payload(vb, 0, video->fmt.fmt.pix.sizeimage); > if (vb2_plane_vaddr(vb, 0) && Thanks, Mauro
