val and sd->gain are unsigned so the tests did not work. Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx> --- Found using coccinelle: http://coccinelle.lip6.fr/ diff --git a/drivers/media/video/gspca/ov534.c b/drivers/media/video/gspca/ov534.c index 4dbb882..f5d1f18 100644 --- a/drivers/media/video/gspca/ov534.c +++ b/drivers/media/video/gspca/ov534.c @@ -1536,7 +1536,7 @@ static void setsharpness_96(struct gspca_dev *gspca_dev) u8 val; val = sd->sharpness; - if (val < 0) { /* auto */ + if (val == -1) { /* auto */ val = sccb_reg_read(gspca_dev, 0x42); /* com17 */ sccb_reg_write(gspca_dev, 0xff, 0x00); sccb_reg_write(gspca_dev, 0x42, val | 0x40); diff --git a/drivers/media/video/gspca/sn9c20x.c b/drivers/media/video/gspca/sn9c20x.c index b1944a7..7ebabe7 100644 --- a/drivers/media/video/gspca/sn9c20x.c +++ b/drivers/media/video/gspca/sn9c20x.c @@ -2319,7 +2319,7 @@ static void do_autogain(struct gspca_dev *gspca_dev, u16 avg_lum) } } if (avg_lum > MAX_AVG_LUM) { - if (sd->gain - 1 >= 0) { + if (sd->gain >= 1) { sd->gain--; set_gain(gspca_dev); } -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
