Re: [PATCH] media: vsp1_dl: add a description for cmdpool field

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mauro,

Thank you for the patch,

On 07/08/18 11:18, Mauro Carvalho Chehab wrote:
> Gets rid of this build warning:
> 	drivers/media/platform/vsp1/vsp1_dl.c:229: warning: Function parameter or member 'cmdpool' not described in 'vsp1_dl_manager'
> 
> Fixes: f3b98e3c4d2e ("media: vsp1: Provide support for extended command pools")
> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@xxxxxxxxxx>
> ---
>  drivers/media/platform/vsp1/vsp1_dl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/vsp1/vsp1_dl.c b/drivers/media/platform/vsp1/vsp1_dl.c
> index 9255b5ee2cb8..af60d95ec4f8 100644
> --- a/drivers/media/platform/vsp1/vsp1_dl.c
> +++ b/drivers/media/platform/vsp1/vsp1_dl.c
> @@ -211,6 +211,7 @@ struct vsp1_dl_list {
>   * @queued: list queued to the hardware (written to the DL registers)
>   * @pending: list waiting to be queued to the hardware
>   * @pool: body pool for the display list bodies
> + * @cmdpool: Display List commands pool

Unfortunately this isn't quite right...


>   * @autofld_cmds: command pool to support auto-fld interlaced mode

This ^ was the original documentation line, but it got missed in a
rename. Sorry about that.

The pool is now more 'generic' so the line probably should mention the
auto-fld directly, so your line is worded appropriately enough, We
probably just# need to remove the autofld_cmds line.


With that line removed:

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>

--
Kieran



>   */
>  struct vsp1_dl_manager {
> 




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux