Hi Jacopo, Thank you for sending your implementation of this. I'm dropping my DT bindings and taking yours. On 09/06/18 12:30, Jacopo Mondi wrote: > IMI D&D RDACM20 automotive platform is a Gigabit Multimedia Serial Link > (GMSL) camera transmitting video and I2C control messages on coax cable > physical link. > > Document its device tree binding interface. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> > --- > .../devicetree/bindings/media/i2c/imi,rdacm20.txt | 62 ++++++++++++++++++++++ > 1 file changed, 62 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/imi,rdacm20.txt There's no update to the vendor-prefixes here to pull in the imi prefix. I'll bring over the version in my patch. -- Regards Kieran > > diff --git a/Documentation/devicetree/bindings/media/i2c/imi,rdacm20.txt b/Documentation/devicetree/bindings/media/i2c/imi,rdacm20.txt > new file mode 100644 > index 0000000..7fda068 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/imi,rdacm20.txt > @@ -0,0 +1,62 @@ > +IMI D&D RDACM20 Automotive Camera Platform > +------------------------------------------ > + > +The IMI D&D RDACM20 is a GMSL-compatible camera designed for automotive > +applications. It is encloses a Maxim Integrated MAX9271 GMSL serializer, an > +Omnivision OV10635 camera sensor and an embedded MCU, and connects to a remote > +GMSL endpoint through a coaxial cable. > + > + IMI RDACM20 > + --------------- -------------------------------- > +| GMSL | <--- Video Stream | <- Video--------\ | > +| |< ====== GMSL Link ======== >|MAX9271<- I2C bus-> <-->OV10635 | > +| de-serializer | <--- I2C messages ---> | \<-->MCU | > + --------------- -------------------------------- I love the ascii art :D > + > +RDACM20 transmits video data generated by the embedded camera sensor on the > +GMSL serial channel to a remote GMSL de-serializer, as well as it receives and > +transmits I2C messages encapsulated in the GMSL bidirectional control channel. > + > +All I2C traffic received on the GMSL link not directed to the serializer is > +propagated on the local I2C bus to the embedded camera sensor and MCU. All > +I2C traffic generated on the local I2C bus not directed to the serializer is > +propagated to the remote de-serializer encapsulated in the GMSL control channel. > + > +Required Properties: > + > +- compatible: Shall be "imi,rdacm20". > +- reg: Pair of I2C device addresses, the first to be assigned to the serializer > + the second to be assigned to the camera sensor. > + > +Connection to the remote GMSL endpoint are modeled using the OF graph bindings s/modeled/modelled/ I'll fix that one :) > +in accordance with the video interface bindings defined in > +Documentation/devicetree/bindings/media/video-interfaces.txt. > + > +The device node contains a single "port" child node with a single "endpoint" > +sub-device. > + > +Required endpoint properties: > + > +- remote-endpoint: phandle to the remote GMSL endpoint sub-node in the remote > + node port. > + > +Example: > +------- > + > + i2c@0 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0>; > + > + camera@51 { > + compatible = "imi,rdacm20"; > + reg = <0x51 0x61>; > + > + port { > + rdacm20_out0: endpoint { > + remote-endpoint = <&max9286_in0>; > + }; > + }; > + > + }; > + }; >