On 08/03/2018 04:36 PM, Hans Verkuil wrote: > From: Hans Verkuil <hans.verkuil@xxxxxxxxx> > > This RFC patch series implements properties for the media controller. > > This is not finished, but I wanted to post this so people can discuss > this further. > > No documentation yet (too early for that). > > An updated v4l2-ctl and v4l2-compliance that can report properties > is available here: > > https://git.linuxtv.org/hverkuil/v4l-utils.git/log/?h=props > > There is one main missing piece: currently the properties are effectively > laid out in random order. My plan is to change that so they are grouped > by object type and object owner. So first all properties for each entity, > then for each pad, etc. I started to work on that, but it's a bit more > work than expected and I wanted to post this before the weekend. > > While it is possible to have nested properties, this is not currently > implemented. Only properties for entities and pads are supported in this > code, but that's easy to extend to interfaces and links. > > I'm not sure about the G_TOPOLOGY ioctl handling: I went with the quickest > option by renaming the old ioctl and adding a new one with property support. > > I think this needs to change (at the very least the old and new should > share the same ioctl NR), but that's something for the future. > > Currently I support u64, s64 and const char * property types. But it > can be anything including binary data if needed. No array support (as we > have for controls), but there are enough reserved fields in media_v2_prop > to add this if needed. > > I added properties for entities and pads to vimc, so I could test this. I forgot to mention that there are known issues with the initialization of the entity props list (it happens in two places, I need to look into that) and that mdev is expected to be valid when adding properties, but I don't think that is necessarily the case. So just be aware of that. Regards, Hans > > Regards, > > Hans > > Hans Verkuil (3): > uapi/linux/media.h: add property support > media: add support for properties > vimc: add test properties > > drivers/media/media-device.c | 98 +++++++++++- > drivers/media/media-entity.c | 65 ++++++++ > drivers/media/platform/vimc/vimc-common.c | 18 +++ > drivers/media/platform/vimc/vimc-core.c | 6 +- > include/media/media-device.h | 6 + > include/media/media-entity.h | 172 ++++++++++++++++++++++ > include/uapi/linux/media.h | 62 +++++++- > 7 files changed, 420 insertions(+), 7 deletions(-) >
