On 08/02/18 18:45, Rui Miguel Silva wrote: > Hi Hans, > On Thu 02 Aug 2018 at 13:37, Hans Verkuil wrote: >> Hi Rui, >> >> On 05/22/18 16:52, Rui Miguel Silva wrote: >>> Hi, >>> This series introduces the Media driver to work with the i.MX7 >>> SoC. it uses the >>> already existing imx media core drivers but since the i.MX7, >>> contrary to >>> i.MX5/6, do not have an IPU and because of that some changes in >>> the imx media >>> core are made along this series to make it support that case. >>> >>> This patches adds CSI and MIPI-CSI2 drivers for i.MX7, along >>> with several >>> configurations changes for this to work as a capture subsystem. >>> Some bugs are >>> also fixed along the line. And necessary documentation. >>> >>> For a more detailed view of the capture paths, pads links in >>> the i.MX7 please >>> take a look at the documentation in PATCH 14. >>> >>> The system used to test and develop this was the Warp7 board >>> with an OV2680 >>> sensor, which output format is 10-bit bayer. So, only MIPI >>> interface was >>> tested, a scenario with an parallel input would nice to have. >>> >>> *Important note*, this code depends on Steve Longerbeam series >>> [0]: >>> [PATCH v4 00/13] media: imx: Switch to subdev notifiers >>> which the merging status is not clear to me, but the changes in >>> there make >>> senses to this series >>> >>> Bellow goes an example of the output of the pads and links and >>> the output of >>> v4l2-compliance testing. >>> >>> The v4l-utils version used is: >>> v4l2-compliance SHA : >>> 47d43b130dc6e9e0edc900759fb37649208371e4 from Apr 4th. >>> >>> The Media Driver fail some tests but this failures are coming >>> from code out of >>> scope of this series (video-mux, imx-capture), and some from >>> the sensor OV2680 >>> but that I think not related with the sensor driver but with >>> the testing and >>> core. >>> >>> The csi and mipi-csi entities pass all compliance tests. >>> >>> Cheers, >>> Rui >>> >>> [0]: >>> https://www.mail-archive.com/linux-media@xxxxxxxxxxxxxxx/msg131186.html >> >> This patch series was delayed quite a bit since the patch series >> above >> it depends on is still not merged. >> >> But the v6 version of that series will be merged once the 4.20 >> cycle opens: >> https://www.mail-archive.com/linux-media@xxxxxxxxxxxxxxx/msg133391.html > > Good news. > >> >> Sakari has a branch with that series on top of the latest >> media_tree master: >> https://git.linuxtv.org/sailus/media_tree.git/log/?h=v4l2-fwnode >> >> Can you rebase this imx7 series on top of that? And test it >> again with the >> *latest* v4l2-compliance? (I've added new checks recently, so >> you need to >> update this utility) >> >> Please post the output of the v4l2-compliance test (after fixing >> any issues >> it raises of course), either as a reply to this post or in the >> cover letter >> of a v7 version of this series if you had to make changes. > > Sure, I will rebase on top of Sakari tree and will update the > compliance > tests and run them again. Oops, forgot to mention: you will likely need to update the include/linux/media.h header: Look for MEDIA_V2_ENTITY_HAS_FLAGS and MEDIA_V2_PAD_HAS_INDEX and change 19 to 18 in those defines. This is added for kernel 4.19, but since in our master tree the kernel version is still 4.18 the v4l2-compliance utility thinks these features are not present when in fact they are. Without this change (temporarily since this will automatically be fixed after the 4.19 merge window closes) v4l2-compliance will fail with an error. Regards, Hans
