Hi Sakari, We will test the new flow on Atlas. If everything is fine we will merge the code into patch v3 or v4. Thanks, PC Chen -----Original Message----- From: Sakari Ailus [mailto:sakari.ailus@xxxxxxxxxxxxxxx] Sent: Monday, July 30, 2018 6:39 PM To: Chen, Ping-chung <ping-chung.chen@xxxxxxxxx> Cc: linux-media@xxxxxxxxxxxxxxx; Yeh, Andy <andy.yeh@xxxxxxxxx>; Lai, Jim <jim.lai@xxxxxxxxx>; tfiga@xxxxxxxxxx; grundler@xxxxxxxxxxxx; Mani, Rajmohan <rajmohan.mani@xxxxxxxxx> Subject: Re: [PATCH v2] media: imx208: Add imx208 camera sensor driver Hi Ping-chung, On Mon, Jul 30, 2018 at 05:26:39PM +0800, Ping-chung Chen wrote: > From: "Chen, Ping-chung" <ping-chung.chen@xxxxxxxxx> > > Add a V4L2 sub-device driver for the Sony IMX208 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > > Signed-off-by: Ping-Chung Chen <ping-chung.chen@xxxxxxxxx> Could you add obtaining the valid link frequencies from the firmware, i.e. use v4l2_fwnode_endpoint_alloc_parse()? -- Kind regards, Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxx