Re: [PATCH] media: vimc: Remove redundant free

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Anton,

Thanks for the patch

On 07/27/2018 08:47 AM, Anton Vasilyev wrote:
> Commit 4a29b7090749 ("[media] vimc: Subdevices as modules") removes
> vimc allocation from vimc_probe(), so corresponding deallocation
> on the error path tries to free static memory.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Anton Vasilyev <vasilyev@xxxxxxxxx>

Acked-by: Helen Koike <helen.koike@xxxxxxxxxxxxx>

> ---
>  drivers/media/platform/vimc/vimc-core.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/platform/vimc/vimc-core.c b/drivers/media/platform/vimc/vimc-core.c
> index fe088a953860..9246f265de31 100644
> --- a/drivers/media/platform/vimc/vimc-core.c
> +++ b/drivers/media/platform/vimc/vimc-core.c
> @@ -328,7 +328,6 @@ static int vimc_probe(struct platform_device *pdev)
>  	if (ret) {
>  		media_device_cleanup(&vimc->mdev);
>  		vimc_rm_subdevs(vimc);
> -		kfree(vimc);
>  		return ret;
>  	}
>  
> 

Regards,
Helen



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux