Hi Hans,
Thanks a lot for the review.
On Wed, 2018-07-18 at 11:58 +0200, Hans Verkuil wrote:
> >
> > +
> > +static int
> > +queue_init(void *priv, struct vb2_queue *src_vq, struct vb2_queue *dst_vq)
> > +{
> > + struct rockchip_vpu_ctx *ctx = priv;
> > + int ret;
> > +
> > + src_vq->type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE;
> > + src_vq->io_modes = VB2_MMAP | VB2_USERPTR | VB2_DMABUF;
>
> Any reason for setting USERPTR?
>
> > + src_vq->drv_priv = ctx;
> > + src_vq->ops = &rockchip_vpu_enc_queue_ops;
> > + src_vq->mem_ops = &vb2_dma_contig_memops;
>
> It isn't really useful in combination with dma_contig.
>
Right! I think I just missed it.
> >
> > +
> > +fallback:
> > + /* Default to full frame for incorrect settings. */
> > + ctx->src_crop.width = fmt->width;
> > + ctx->src_crop.height = fmt->height;
> > + return 0;
> > +}
>
> Replace crop by the selection API. The old crop API is no longer allowed
> in new drivers.
I have a question about the selection API. There is a comment that says
MPLANE types shouldn't be used:
/**
* struct v4l2_selection - selection info
* @type: buffer type (do not use *_MPLANE types)
What is the meaning of that?
[..]
>
> I skipped the review of the colorspace handling. I'll see if I can come back
> to that later today. I'm not sure if it is correct, but to be honest I doubt
> that there is any JPEG encoder that does this right anyway.
>
And I'd say it's probably wrong, since we let the user change the colorspace,
but we do not use that for anything.
> BTW, please show the 'v4l2-compliance -s' output in the cover letter for the
> next version.
>
OK, no problem.
Thanks!
Eze
