On 27/07/18 09:59, Hans Verkuil wrote: > Hi Niklas, > > On 17/07/18 14:30, Niklas Söderlund wrote: >> Hi, >> >> These first patch fix a issue which was discussed back in 2016 that the >> field format of the adv7180 should be V4L2_FIELD_ALTERNATE. While the >> second patch adds support for the g_frame_interval video op. >> >> Work is loosely based on work by Steve Longerbeam posted in 2016. I have >> talked to Steven and he have agreed to me taking over the patches as he >> did not intend to continue his work on the original series. >> >> The series is based on the latest media-tree and tested on Renesas >> Koelsch board. >> >> Niklas Söderlund (2): >> adv7180: fix field type to V4L2_FIELD_ALTERNATE >> adv7180: add g_frame_interval support >> >> drivers/media/i2c/adv7180.c | 30 +++++++++++++++++++++++++----- >> 1 file changed, 25 insertions(+), 5 deletions(-) >> > > I've accepted these patches, Sorry, I replied to the v1, but I have accepted the v2 patches of course. Regards, Hans >but I was wondering if the code correctly > initializes the format? It sets the field in probe(), but where does it > set the initial format? > > Should it implement the init_cfg op to initialize the pad configs? > > Regards, > > Hans >
