On 26/07/18 12:20, Tomasz Figa wrote:
> Hi Hans,
>
> On Wed, Jul 25, 2018 at 8:59 PM Hans Verkuil <hverkuil@xxxxxxxxx> wrote:
>>
>> Hi Tomasz,
>>
>> Many, many thanks for working on this! It's a great document and when done
>> it will be very useful indeed.
>>
>> Review comments follow...
>
> Thanks for review!
>
>>
>> On 24/07/18 16:06, Tomasz Figa wrote:
> [snip]
>> Note that the v4l2_pix_format/S_FMT documentation needs to be updated as well
>> since we never allowed 0x0 before.
>
> Is there any text that disallows this? I couldn't spot any. Generally
> there are already drivers which return 0x0 for coded formats (s5p-mfc)
> and it's not even strange, because in such case, the buffer contains
> just a sequence of bytes, not a 2D picture.
All non-m2m devices will always have non-zero width/height values. Only with
m2m devices do we see this.
This was probably never documented since before m2m appeared it was 'obvious'.
This definitely needs to be documented, though.
>
>> What if you set the format to 0x0 but the stream does not have meta data with
>> the resolution? How does userspace know if 0x0 is allowed or not? If this is
>> specific to the chosen coded pixel format, should be add a new flag for those
>> formats indicating that the coded data contains resolution information?
>
> Yes, this would definitely be on a per-format basis. Not sure what you
> mean by a flag, though? E.g. if the format is set to H264, then it's
> bound to include resolution information. If the format doesn't include
> it, then userspace is already aware of this fact, because it needs to
> get this from some other source (e.g. container).
>
>>
>> That way userspace knows if 0x0 can be used, and the driver can reject 0x0
>> for formats that do not support it.
>
> As above, but I might be misunderstanding your suggestion.
So my question is: is this tied to the pixel format, or should we make it
explicit with a flag like V4L2_FMT_FLAG_CAN_DECODE_WXH.
The advantage of a flag is that you don't need a switch on the format to
know whether or not 0x0 is allowed. And the flag can just be set in
v4l2-ioctls.c.
>>> +STREAMOFF-STREAMON sequence on it is intended solely for changing buffer
>>> +sets.
>>
>> 'changing buffer sets': not clear what is meant by this. It's certainly not
>> 'solely' since it can also be used to achieve an instantaneous seek.
>>
>
> To be honest, I'm not sure whether there is even a need to include
> this whole section. It's obvious that if you stop feeding a mem2mem
> device, it will pause. Moreover, other sections imply various
> behaviors triggered by STREAMOFF/STREAMON/DECODER_CMD/etc., so it
> should be quite clear that they are different from a simple pause.
> What do you think?
Yes, I'd drop this last sentence ('Similarly...sets').
>>> +2. After all buffers containing decoded frames from before the resolution
>>> + change point are ready to be dequeued on the ``CAPTURE`` queue, the
>>> + driver sends a ``V4L2_EVENT_SOURCE_CHANGE`` event for source change
>>> + type ``V4L2_EVENT_SRC_CH_RESOLUTION``.
>>> +
>>> + * The last buffer from before the change must be marked with
>>> + :c:type:`v4l2_buffer` ``flags`` flag ``V4L2_BUF_FLAG_LAST`` as in the
>>
>> spurious 'as'?
>>
>
> It should be:
>
> * The last buffer from before the change must be marked with
> the ``V4L2_BUF_FLAG_LAST`` flag in :c:type:`v4l2_buffer` ``flags`` field,
> similarly to the
Ah, OK. Now I get it.
>> I wonder if we should make these min buffer controls required. It might be easier
>> that way.
>
> Agreed. Although userspace is still free to ignore it, because REQBUFS
> would do the right thing anyway.
It's never been entirely clear to me what the purpose of those min buffers controls
is. REQBUFS ensures that the number of buffers is at least the minimum needed to
make the HW work. So why would you need these controls? It only makes sense if they
return something different from REQBUFS.
>
>>
>>> +7. If all the following conditions are met, the client may resume the
>>> + decoding instantly, by using :c:func:`VIDIOC_DECODER_CMD` with
>>> + ``V4L2_DEC_CMD_START`` command, as in case of resuming after the drain
>>> + sequence:
>>> +
>>> + * ``sizeimage`` of new format is less than or equal to the size of
>>> + currently allocated buffers,
>>> +
>>> + * the number of buffers currently allocated is greater than or equal to
>>> + the minimum number of buffers acquired in step 6.
>>
>> You might want to mention that if there are insufficient buffers, then
>> VIDIOC_CREATE_BUFS can be used to add more buffers.
>>
>
> This might be a bit tricky, since at least s5p-mfc and coda can only
> work on a fixed buffer set and one would need to fully reinitialize
> the decoding to add one more buffer, which would effectively be the
> full resolution change sequence, as below, just with REQBUFS(0),
> REQBUFS(N) replaced with CREATE_BUFS.
What happens today in those drivers if you try to call CREATE_BUFS?
Regards,
Hans
