On Wed, 2018-07-18 at 12:23 +0200, Hans Verkuil wrote: > On 12/07/18 17:43, Ezequiel Garcia wrote: > > v4l2_m2m_try_run() has only one caller and so it's possible > > to move its contents. > > > > Although this de-modularization change could reduce clarity, > > in this case it allows to remove a spinlock lock/unlock pair > > and an unneeded sanity check. > > > > Signed-off-by: Ezequiel Garcia <ezequiel@xxxxxxxxxxxxx> > > This patch no longer applies, can you respin? > I think that is because it applies on top of: v4l2-mem2mem: Simplify exiting the function in v4l2_m2m_try_schedule The v4l2_m2m_try_schedule function acquires and releases multiple spinlocks; simplify unlocking the job lock by adding a label to unlock the job lock and exit the function. which I cherry-picked from the Request API series. I will include this patch in my next submit, in case you want to take the series soon(ishly). Thanks, Ezequiel