Re: [PATCH v2 1/2] media: dt-bindings: bind nokia,n900-ir to generic pwm-ir-tx driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 13, 2018 at 01:13:20PM +0200, Pavel Machek wrote:
> Hi!
> 
> > Signed-off-by: Sean Young <sean@xxxxxxxx>
> > ---
> >  .../devicetree/bindings/media/nokia,n900-ir   | 20 -------------------
> >  arch/arm/boot/dts/omap3-n900.dts              |  2 +-
> >  drivers/media/rc/pwm-ir-tx.c                  |  1 +
> >  3 files changed, 2 insertions(+), 21 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/media/nokia,n900-ir
> > 
> > diff --git a/Documentation/devicetree/bindings/media/nokia,n900-ir b/Documentation/devicetree/bindings/media/nokia,n900-ir
> > deleted file mode 100644
> > index 13a18ce37dd1..000000000000
> > --- a/Documentation/devicetree/bindings/media/nokia,n900-ir
> > +++ /dev/null
> > @@ -1,20 +0,0 @@
> > -Device-Tree bindings for LIRC TX driver for Nokia N900(RX51)
> > -
> > -Required properties:
> > -	- compatible: should be "nokia,n900-ir".
> > -	- pwms: specifies PWM used for IR signal transmission.
> > -
> > -Example node:
> > -
> > -	pwm9: dmtimer-pwm@9 {
> > -		compatible = "ti,omap-dmtimer-pwm";
> > -		ti,timers = <&timer9>;
> > -		ti,clock-source = <0x00>; /* timer_sys_ck */
> > -		#pwm-cells = <3>;
> > -	};
> > -
> > -	ir: n900-ir {
> > -		compatible = "nokia,n900-ir";
> > -
> > -		pwms = <&pwm9 0 26316 0>; /* 38000 Hz */
> > -	};
> 
> Removing documentation is bad idea, I guess. The binding still exists
> and new kernels should still support it.

I've sent out a v3 correcting this.

Thank you for the review!


Sean



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux