On 09/07/18 15:04, Laurent Pinchart wrote: > Hi Hans, > > Thank you for the patch. > > On Friday, 29 June 2018 14:43:27 EEST Hans Verkuil wrote: >> From: Hans Verkuil <hans.verkuil@xxxxxxxxx> >> >> These two drivers both have function MEDIA_ENT_F_DV_ENCODER. >> >> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> >> Acked-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > As this patch is separate from 06/12, I think it would make sense to split the > driver changes from 05/12 to a separate patch. MEDIA_ENT_F_DV_ENCODER is new and hasn't been used before, so I can split it in two patches. MEDIA_ENT_F_DTV_DECODER however was already in use, and since this old define disappeared under #ifndef __KERNEL__ drivers had to be changed in the same patch to prevent bisect fails. Regards, Hans > >> --- >> drivers/media/i2c/ad9389b.c | 1 + >> drivers/media/i2c/adv7511.c | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/drivers/media/i2c/ad9389b.c b/drivers/media/i2c/ad9389b.c >> index 91ff06088572..5b008b0002c0 100644 >> --- a/drivers/media/i2c/ad9389b.c >> +++ b/drivers/media/i2c/ad9389b.c >> @@ -1134,6 +1134,7 @@ static int ad9389b_probe(struct i2c_client *client, >> const struct i2c_device_id * goto err_hdl; >> } >> state->pad.flags = MEDIA_PAD_FL_SINK; >> + sd->entity.function = MEDIA_ENT_F_DV_ENCODER; >> err = media_entity_pads_init(&sd->entity, 1, &state->pad); >> if (err) >> goto err_hdl; >> diff --git a/drivers/media/i2c/adv7511.c b/drivers/media/i2c/adv7511.c >> index 5731751d3f2a..55c2ea0720d9 100644 >> --- a/drivers/media/i2c/adv7511.c >> +++ b/drivers/media/i2c/adv7511.c >> @@ -1847,6 +1847,7 @@ static int adv7511_probe(struct i2c_client *client, >> const struct i2c_device_id * goto err_hdl; >> } >> state->pad.flags = MEDIA_PAD_FL_SINK; >> + sd->entity.function = MEDIA_ENT_F_DV_ENCODER; >> err = media_entity_pads_init(&sd->entity, 1, &state->pad); >> if (err) >> goto err_hdl; > >
