Hi Hans, Thank you for the patch. On Friday, 29 June 2018 14:43:26 EEST Hans Verkuil wrote: > From: Hans Verkuil <hansverk@xxxxxxxxx> > > Keep the function defines in numerical order: 0x6000 comes after > 0x2000, so move it back. > > Signed-off-by: Hans Verkuil <hansverk@xxxxxxxxx> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > include/uapi/linux/media.h | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h > index 6f594fa238c2..76d9bd64c116 100644 > --- a/include/uapi/linux/media.h > +++ b/include/uapi/linux/media.h > @@ -89,13 +89,6 @@ struct media_device_info { > #define MEDIA_ENT_F_FLASH (MEDIA_ENT_F_OLD_SUBDEV_BASE + 2) > #define MEDIA_ENT_F_LENS (MEDIA_ENT_F_OLD_SUBDEV_BASE + 3) > > -/* > - * Video decoder/encoder functions > - */ > -#define MEDIA_ENT_F_ATV_DECODER (MEDIA_ENT_F_OLD_SUBDEV_BASE + 4) > -#define MEDIA_ENT_F_DV_DECODER (MEDIA_ENT_F_BASE + 0x6001) > -#define MEDIA_ENT_F_DV_ENCODER (MEDIA_ENT_F_BASE + 0x6002) > - > /* > * Digital TV, analog TV, radio and/or software defined radio tuner > functions. * > @@ -140,6 +133,13 @@ struct media_device_info { > #define MEDIA_ENT_F_VID_MUX (MEDIA_ENT_F_BASE + 0x5001) > #define MEDIA_ENT_F_VID_IF_BRIDGE (MEDIA_ENT_F_BASE + 0x5002) > > +/* > + * Video decoder/encoder functions > + */ > +#define MEDIA_ENT_F_ATV_DECODER (MEDIA_ENT_F_OLD_SUBDEV_BASE + 4) > +#define MEDIA_ENT_F_DV_DECODER (MEDIA_ENT_F_BASE + 0x6001) > +#define MEDIA_ENT_F_DV_ENCODER (MEDIA_ENT_F_BASE + 0x6002) > + > /* Entity flags */ > #define MEDIA_ENT_FL_DEFAULT (1 << 0) > #define MEDIA_ENT_FL_CONNECTOR (1 << 1) -- Regards, Laurent Pinchart