Abylai Ospan wrote: > On Thu, 2009-12-10 at 17:26 +0300, Abylai Ospan wrote: >> Mauro, >> >> Please pulll change: >> >> http://udev.netup.ru/cgi-bin/hgwebdir.cgi/v4l-dvb-aospan-ci/rev/3b217910057c >> >> "Print bitrate measured by stv0900 demod in stv0900_read_status". >> >> this feature very useful for debugging. > > sorry, here is a correct version of this patch: > > http://udev.netup.ru/cgi-bin/hgwebdir.cgi/v4l-dvb-aospan-ci/rev/cf16baf33f0d > > Please review your patch against checkpatch.pl before posting. It found a number of errors. Also, the patches on your tree doesn't match your description. Please have a separate tree for your pull requests, since I generally pull everything new there instead of cherry-picking patches. Thanks, Mauro --- Number of patches: 5 /tmp/newpatches/hg_v4l-dvb-aospan-ci_1.patch with cs=f8f187cca0ae First patch. Patch against an older patch: changeset: 13576:121066e283e5 user: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> date: Sun Dec 06 09:32:49 2009 -0200 summary: ir-common: fix an oops caused by the usage of an initialized drvdata /tmp/newpatches/hg_v4l-dvb-aospan-ci_2.patch with cs=434bee610181 Ok. /tmp/newpatches/hg_v4l-dvb-aospan-ci_3.patch with cs=cf16baf33f0d Nok/Merge: Old node ID: 434bee61018111f7989a50911a9110cb104d42df Node parents 1e6049b8cb4c6e2ee8c7ff248a84f518de2e65f2 Renamed to /tmp/newpatches/hg_v4l-dvb-aospan-ci_3.merge /tmp/newpatches/hg_v4l-dvb-aospan-ci_3.patch with cs=e628924d44af Ok. /tmp/newpatches/hg_v4l-dvb-aospan-ci_4.patch with cs=9891ba1f0e06 Ok. Diffstat of the imported series: linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c | 32 ++ linux/drivers/media/video/cx23885/cimax2.c | 156 ++++++++------ 2 files changed, 130 insertions(+), 58 deletions(-) /tmp/newpatches/hg_v4l-dvb-aospan-ci_2.patch: CAM module WE bit processing workaround WARNING: line over 80 characters #18: FILE: linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c:722: + if ((status = ca->pub->read_cam_control(ca->pub, slot, CTRLIF_STATUS)) < 0) ERROR: do not use assignment in if condition #18: FILE: linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c:722: + if ((status = ca->pub->read_cam_control(ca->pub, slot, CTRLIF_STATUS)) < 0) ERROR: space prohibited before that close parenthesis ')' #21: FILE: linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c:725: + if ((status & STATUSREG_WE )) { WARNING: printk() should include KERN_ facility level #22: FILE: linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c:726: + printk("CAM module WE bit set when starting write operation. \n"); ERROR: spaces required around that '=' (ctx:VxV) #23: FILE: linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c:727: + for(i=0; i < 100; i++){ ^ ERROR: space required before the open brace '{' #23: FILE: linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c:727: + for(i=0; i < 100; i++){ ERROR: space required before the open parenthesis '(' #23: FILE: linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c:727: + for(i=0; i < 100; i++){ WARNING: line over 80 characters #24: FILE: linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c:728: + if ((status = ca->pub->write_cam_control(ca->pub, slot, CTRLIF_DATA, 0x0 )) != 0) ERROR: space prohibited before that close parenthesis ')' #24: FILE: linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c:728: + if ((status = ca->pub->write_cam_control(ca->pub, slot, CTRLIF_DATA, 0x0 )) != 0) ERROR: do not use assignment in if condition #24: FILE: linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c:728: + if ((status = ca->pub->write_cam_control(ca->pub, slot, CTRLIF_DATA, 0x0 )) != 0) WARNING: line over 80 characters #26: FILE: linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c:730: + status = ca->pub->read_cam_control(ca->pub, slot, CTRLIF_STATUS); WARNING: line over 80 characters #27: FILE: linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c:731: + dprintk("CAM module WE. CA writing byte %d status 0x%x\n", i, status); ERROR: space prohibited after that open parenthesis '(' #29: FILE: linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c:733: + if( !(status & STATUSREG_WE )) ERROR: space prohibited before that close parenthesis ')' #29: FILE: linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c:733: + if( !(status & STATUSREG_WE )) ERROR: space required before the open parenthesis '(' #29: FILE: linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c:733: + if( !(status & STATUSREG_WE )) total: 10 errors, 5 warnings, 22 lines checked /tmp/newpatches/hg_v4l-dvb-aospan-ci_4.patch: CAM module WE bit processing workaround WARNING: line over 80 characters #18: FILE: linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c:722: + if ((status = ca->pub->read_cam_control(ca->pub, slot, CTRLIF_STATUS)) < 0) ERROR: do not use assignment in if condition #18: FILE: linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c:722: + if ((status = ca->pub->read_cam_control(ca->pub, slot, CTRLIF_STATUS)) < 0) ERROR: space prohibited before that close parenthesis ')' #21: FILE: linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c:725: + if ((status & STATUSREG_WE )) { WARNING: printk() should include KERN_ facility level #22: FILE: linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c:726: + printk("CAM module WE bit set when starting write operation. \n"); ERROR: spaces required around that '=' (ctx:VxV) #23: FILE: linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c:727: + for(i=0; i < 100; i++){ ^ ERROR: space required before the open brace '{' #23: FILE: linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c:727: + for(i=0; i < 100; i++){ ERROR: space required before the open parenthesis '(' #23: FILE: linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c:727: + for(i=0; i < 100; i++){ WARNING: line over 80 characters #24: FILE: linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c:728: + if ((status = ca->pub->write_cam_control(ca->pub, slot, CTRLIF_DATA, 0x0 )) != 0) ERROR: space prohibited before that close parenthesis ')' #24: FILE: linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c:728: + if ((status = ca->pub->write_cam_control(ca->pub, slot, CTRLIF_DATA, 0x0 )) != 0) ERROR: do not use assignment in if condition #24: FILE: linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c:728: + if ((status = ca->pub->write_cam_control(ca->pub, slot, CTRLIF_DATA, 0x0 )) != 0) WARNING: line over 80 characters #26: FILE: linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c:730: + status = ca->pub->read_cam_control(ca->pub, slot, CTRLIF_STATUS); WARNING: line over 80 characters #27: FILE: linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c:731: + dprintk("CAM module WE. CA writing byte %d status 0x%x\n", i, status); ERROR: space prohibited after that open parenthesis '(' #29: FILE: linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c:733: + if( !(status & STATUSREG_WE )) ERROR: space prohibited before that close parenthesis ')' #29: FILE: linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c:733: + if( !(status & STATUSREG_WE )) ERROR: space required before the open parenthesis '(' #29: FILE: linux/drivers/media/dvb/dvb-core/dvb_ca_en50221.c:733: + if( !(status & STATUSREG_WE )) total: 10 errors, 5 warnings, 22 lines checked -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
