Jean-Francois Moine wrote: > On Fri, 11 Dec 2009 22:33:36 +0100 > Németh Márton <nm127@xxxxxxxxxxx> wrote: > >> From: Márton Németh <nm127@xxxxxxxxxxx> >> >> Eliminate the following sparse warnings (see "make C=1"): >> * v4l/m5602_s5k4aa.c:530:23: warning: dubious: x | !y >> * v4l/m5602_s5k4aa.c:575:23: warning: dubious: x | !y >> >> Signed-off-by: Márton Németh <nm127@xxxxxxxxxxx> >> --- >> ../../m5602_s5k4aa_dubious.patch >> diff -r f5662ce08663 >> linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c --- >> a/linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c Fri Dec >> 11 09:53:41 2009 +0100 +++ >> b/linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c Fri Dec >> 11 22:25:50 2009 +0100 @@ -527,7 +527,7 @@ err = >> m5602_read_sensor(sd, S5K4AA_ROWSTART_LO, &data, 1); if (err < 0) >> return err; >> - data = (data & 0xfe) | !val; >> + data = (data & 0xfe) | (val ? 0 : 1); >> err = m5602_write_sensor(sd, S5K4AA_ROWSTART_LO, &data, 1); >> return err; >> } >> @@ -572,7 +572,7 @@ >> err = m5602_read_sensor(sd, S5K4AA_COLSTART_LO, &data, 1); >> if (err < 0) >> return err; >> - data = (data & 0xfe) | !val; >> + data = (data & 0xfe) | (val ? 0 : 1); >> err = m5602_write_sensor(sd, S5K4AA_COLSTART_LO, &data, 1); >> return err; >> } > > Thanks, but I fixed it in an other way. No problem as long as the warning message is removed. Regards, Márton Németh -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
