Re: [PATCH 1/2] media: i2c: ov5640: Re-work MIPI start sequence

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 29, 2018 at 06:42:39PM +0200, Jacopo Mondi wrote:
> From: Jacopo Mondi <jacopo@xxxxxxxxxx>
> 
> Change the MIPI CSI-2 interface startup sequence to the following:
> 
> Initialization:
> 0x3019 = 0x70 : Lane1, Lane2 and clock in LP11 when in 'sleep mode'
> 0x300e = 0x58 : 2 lanes mode, power down TX and RX, MIPI CSI-2 off
> 0x4800 = 0x20 : Gate clock when not transmitting, LP00 when not transmitting
> 
> Stream on:
> 0x300e = 0x4c : 2 lanes mode, power up TX and enable MIPI
> 
> Stream off:
> 0x300e = 0x58 : 2 lanes mode, power down TX and RX, MIPI CSI-2 off
> 
> Signed-off-by: Jacopo Mondi <jacopo@xxxxxxxxxx>
> ---
>  drivers/media/i2c/ov5640.c | 26 ++++++++++++++++++--------
>  1 file changed, 18 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
> index 1ecbb7a..465acce 100644
> --- a/drivers/media/i2c/ov5640.c
> +++ b/drivers/media/i2c/ov5640.c
> @@ -259,6 +259,7 @@ static inline struct v4l2_subdev *ctrl_to_sd(struct v4l2_ctrl *ctrl)
>  static const struct reg_value ov5640_init_setting_30fps_VGA[] = {
>  	{0x3103, 0x11, 0, 0}, {0x3008, 0x82, 0, 5}, {0x3008, 0x42, 0, 0},
>  	{0x3103, 0x03, 0, 0}, {0x3017, 0x00, 0, 0}, {0x3018, 0x00, 0, 0},
> +	{0x3019, 0x70, 0, 0},

I'd really prefer to remove parts of that array, instead of adding
more to that unmaintainable blob.

Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux