On 06/27/2018 06:39 PM, Matt Ranostay wrote:
On Wed, Jun 27, 2018 at 3:43 PM, kbuild test robot <lkp@xxxxxxxxx> wrote:
Hi Matt,
I love your patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.18-rc2 next-20180627]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Matt-Ranostay/media-video-i2c-add-hwmon-support-for-amg88xx/20180628-032019
base: git://linuxtv.org/media_tree.git master
config: x86_64-randconfig-g0-06280029 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/media/i2c/video-i2c.o: In function `amg88xx_hwmon_init':
drivers/media/i2c/video-i2c.c:167: undefined reference to `devm_hwmon_device_register_with_info'
vim +167 drivers/media/i2c/video-i2c.c
Guenter,
Before I resubmit this change do you agree an "imply HWMON" in the
Kconfig is the right way to avoid this race condition on build?
Using 'select HWMON' would of course defeat the purpose of '#if
IS_ENABLED(CONFIG_HWMON)'
Looks like it, but you'll have to try. I have not used it myself, so I
don't really know what exactly it does. Another option might be to use
IS_REACHABLE().
Guenter
Thanks,
Matt
164
165 static int amg88xx_hwmon_init(struct video_i2c_data *data)
166 {
> 167 void *hwmon = devm_hwmon_device_register_with_info(&data->client->dev,
168 "amg88xx", data, &amg88xx_chip_info, NULL);
169
170 return PTR_ERR(hwmon);
171 }
172 #else
173 #define amg88xx_hwmon_init NULL
174 #endif
175
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
