> After reviewing the patch as well as the spec, your change looks > pretty reasonable (aside from the fact that you need the other USB > IDs). It seems pretty clear that the au0828 violates the spec, but > the spec does indicate how to handle that case, which is what your > code addresses. > I think you found something in the specification I haven't found. What did you see that indicated how to deal with equipment misbehaving in this way? I found the following list of USB ID's. Just double checking, but is the 850 enough like the 950 line for me to include it? case 72000: /* WinTV-HVR950q (Retail, IR, ATSC/QAM */ case 72001: /* WinTV-HVR950q (Retail, IR, ATSC/QAM and analog video */ case 72211: /* WinTV-HVR950q (OEM, IR, ATSC/QAM and analog video */ case 72221: /* WinTV-HVR950q (OEM, IR, ATSC/QAM and analog video */ case 72231: /* WinTV-HVR950q (OEM, IR, ATSC/QAM and analog video */ case 72241: /* WinTV-HVR950q (OEM, No IR, ATSC/QAM and analog video */ case 72251: /* WinTV-HVR950q (Retail, IR, ATSC/QAM and analog video */ --> case 72301: /* WinTV-HVR850 (Retail, IR, ATSC and analog video */ case 72500: /* WinTV-HVR950q (OEM, No IR, ATSC/QAM */ Thanks again, not only for your help with my change, but with all you did to provide support for the Hauppage equipment. I'd add that being the beginner at making kernel changes your review is particularly helpful to me (and to my confidence). John -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html