On Wed, May 09, 2018 at 03:31:59PM +0100, Rui Miguel Silva wrote:
...
> +static int ov2680_init_cfg(struct v4l2_subdev *sd,
> + struct v4l2_subdev_pad_config *cfg)
> +{
> + struct ov2680_dev *sensor = to_ov2680_dev(sd);
> + struct v4l2_mbus_framefmt *mf;
> +
> + mf = v4l2_subdev_get_try_format(sd, cfg, 0);
> +
> + *mf = sensor->fmt;
The init_cfg callback is intended for initialising the format configuration
(as well as compose and crop where relevant) to the device default values.
The implementation in e.g. drivers/media/i2c/ov7251.c seems abour right,
for instance.
I think this would be relevant in addressing the compile issues without
subdev uAPI, too.
I've postponed the two patches, feel free to send either delta or v7 of
this.
--
Sakari Ailus
sakari.ailus@xxxxxxxxxxxxxxx
