Hi Luca, On Mon, Jun 11, 2018 at 01:35:31PM +0200, Luca Ceresoli wrote: > Hi, > > this patchset introduces cropping support for the Sony IMX274 sensor > using the SELECTION API. > > With respect to v3, this version uses the SELECTION API with taget > V4L2_SEL_TGT_COMPOSE to change the output resolution. This is the > recommended API for cropping + downscaling. However for backward > compatibility the set_format callback is still supported and is > equivalent to setting the compose rect as far as resolutions are > concerned. > > Patches 1-5 are overall improvements and restructuring, mostly useful > to implement the SELECTION API in a clean way. > > Patch 6 introduces a helper to allow setting many registers computed > at runtime in a straightforward way. This would not have been very > useful before because all long register write sequences came from > const tables, but it's definitely a must for the cropping code where > several register values are computed at runtime. > > Patch 7 is new in this series, it's a trivial typo fix that can be > applied independently. > > Patch 8 implements the set_selection pad operation for cropping > (V4L2_SEL_TGT_CROP) and binning (V4L2_SEL_TGT_COMPOSE). The most > tricky part was respecting all the device constraints on the > horizontal crop. My apologies for delays in reviewing the set. I'll take patches 1--5 and 7 and then I'll comment on patches 6 and 8 separately. Would that work for you? -- Kind regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx
