Hi Daniel, Thank you for the patch. On Monday, 25 June 2018 16:21:32 EEST Daniel Graefe wrote: > Added missing SPDX license identifiers to all files of the omap4iss > driver. > > Most files already have license texts which clearly state them to be > licensed under GPL 2.0 or later. SPDX identifiers were added accordingly. > > Some files do not have any license text. SPDX identifiers for GPL 2.0 > were added to them, in accordance with the default license of the > kernel. > > Signed-off-by: Daniel Graefe <daniel.graefe@xxxxxx> > Signed-off-by: Roman Sommer <roman.sommer@xxxxxx> > --- > drivers/staging/media/omap4iss/Kconfig | 2 ++ > drivers/staging/media/omap4iss/Makefile | 3 +++ > drivers/staging/media/omap4iss/iss.c | 1 + > drivers/staging/media/omap4iss/iss.h | 1 + > drivers/staging/media/omap4iss/iss_csi2.c | 1 + > drivers/staging/media/omap4iss/iss_csi2.h | 1 + > drivers/staging/media/omap4iss/iss_csiphy.c | 1 + > drivers/staging/media/omap4iss/iss_csiphy.h | 1 + > drivers/staging/media/omap4iss/iss_ipipe.c | 1 + > drivers/staging/media/omap4iss/iss_ipipe.h | 1 + > drivers/staging/media/omap4iss/iss_ipipeif.c | 1 + > drivers/staging/media/omap4iss/iss_ipipeif.h | 1 + > drivers/staging/media/omap4iss/iss_regs.h | 1 + > drivers/staging/media/omap4iss/iss_resizer.c | 1 + > drivers/staging/media/omap4iss/iss_resizer.h | 1 + > drivers/staging/media/omap4iss/iss_video.c | 1 + > drivers/staging/media/omap4iss/iss_video.h | 1 + > 17 files changed, 20 insertions(+) > > diff --git a/drivers/staging/media/omap4iss/Kconfig > b/drivers/staging/media/omap4iss/Kconfig index dddd273..841cc0b 100644 > --- a/drivers/staging/media/omap4iss/Kconfig > +++ b/drivers/staging/media/omap4iss/Kconfig > @@ -1,3 +1,5 @@ > +# SPDX-License-Identifier: GPL-2.0 > + > config VIDEO_OMAP4 > tristate "OMAP 4 Camera support" > depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && I2C > diff --git a/drivers/staging/media/omap4iss/Makefile > b/drivers/staging/media/omap4iss/Makefile index a716ce9..e64d489 100644 > --- a/drivers/staging/media/omap4iss/Makefile > +++ b/drivers/staging/media/omap4iss/Makefile > @@ -1,4 +1,7 @@ > +# SPDX-License-Identifier: GPL-2.0 > +# > # Makefile for OMAP4 ISS driver > +# > > omap4-iss-objs += \ > iss.o iss_csi2.o iss_csiphy.o iss_ipipeif.o iss_ipipe.o iss_resizer.o > iss_video.o diff --git a/drivers/staging/media/omap4iss/iss.c > b/drivers/staging/media/omap4iss/iss.c index b1036ba..0c41939 100644 > --- a/drivers/staging/media/omap4iss/iss.c > +++ b/drivers/staging/media/omap4iss/iss.c > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later The SPDX identifier used for "GPL v2.0 or later" in the kernel is GPL-2.0+, as documented in Documentation/process/license-rules.rst. I'm aware that that identifier has been deprecated by the FSF in favour of the GPL-2.0-or-later identifier, but until Documentation/process/license-rules.rst gets updated, please use GPL-2.0+. > /* > * TI OMAP4 ISS V4L2 Driver > * Could you please remove the boilerplate license text, as it's not needed anymore ? Those two comments apply to all the other files. [snip$ -- Regards, Laurent Pinchart