RE: [v1, 2/2] dt-bindings: at24: Add address-width property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Alan,

Thanks for the patch set.
You should change the subject as below.
[PATCH v1, 1/2]
[PATCH v1, 2/2]

And I think you may missed to create a cover page. Please follow my BKM. Thanks.
git format-patch --cover --subject-prefix <version> -o <output folder> HEAD~n


Regards, Andy

> -----Original Message-----
> From: Chiang, AlanX
> Sent: Friday, June 22, 2018 5:47 PM
> To: linux-media@xxxxxxxxxxxxxxx
> Cc: Yeh, Andy <andy.yeh@xxxxxxxxx>; sakari.ailus@xxxxxxxxxxxxxxx;
> Shevchenko, Andriy <andriy.shevchenko@xxxxxxxxx>; Mani, Rajmohan
> <rajmohan.mani@xxxxxxxxx>; Chiang, AlanX <alanx.chiang@xxxxxxxxx>
> Subject: [v1, 2/2] dt-bindings: at24: Add address-width property
> 
> From: "alanx.chiang" <alanx.chiang@xxxxxxxxx>
> 
> The AT24 series chips use 8-bit address by default. If some chips would like to
> support more than 8 bits, the at24 driver should be added the compatible
> field for specfic chips.
> 
> Provide a flexible way to determine the addressing bits through address-width
> in this patch.
> 
> Signed-off-by: Alan Chiang <alanx.chiang@xxxxxxxxx>
> Signed-off-by: Andy Yeh <andy.yeh@xxxxxxxxx>
> Reviewed-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
> Reviewed-by: Rajmohan Mani <rajmohan.mani@xxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/eeprom/at24.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt
> b/Documentation/devicetree/bindings/eeprom/at24.txt
> index 61d833a..5879259 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.txt
> +++ b/Documentation/devicetree/bindings/eeprom/at24.txt
> @@ -72,6 +72,8 @@ Optional properties:
> 
>    - wp-gpios: GPIO to which the write-protect pin of the chip is connected.
> 
> +  - address-width : number of address bits (one of 8, 16).
> +
>  Example:
> 
>  eeprom@52 {
> @@ -79,4 +81,5 @@ eeprom@52 {
>  	reg = <0x52>;
>  	pagesize = <32>;
>  	wp-gpios = <&gpio1 3 0>;
> +	address-width = <16>;
>  };
> --
> 2.7.4




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux