Re: [PATCH 1/2] media: add helpers for memory-to-memory media controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ezequiel,

I love your patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.18-rc1 next-20180620]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Ezequiel-Garcia/media-add-helpers-for-memory-to-memory-media-controller/20180621-050216
base:   git://linuxtv.org/media_tree.git master
config: x86_64-randconfig-x012-201824 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/media/v4l2-core/v4l2-mem2mem.c: In function 'v4l2_m2m_unregister_media_controller':
>> drivers/media/v4l2-core/v4l2-mem2mem.c:624:34: error: 'struct v4l2_m2m_dev' has no member named 'intf_devnode'
     media_remove_intf_links(&m2m_dev->intf_devnode->intf);
                                     ^~
   drivers/media/v4l2-core/v4l2-mem2mem.c:625:30: error: 'struct v4l2_m2m_dev' has no member named 'intf_devnode'
     media_devnode_remove(m2m_dev->intf_devnode);
                                 ^~
>> drivers/media/v4l2-core/v4l2-mem2mem.c:627:35: error: 'struct v4l2_m2m_dev' has no member named 'source'
     media_entity_remove_links(m2m_dev->source);
                                      ^~
>> drivers/media/v4l2-core/v4l2-mem2mem.c:628:36: error: 'struct v4l2_m2m_dev' has no member named 'sink'
     media_entity_remove_links(&m2m_dev->sink);
                                       ^~
>> drivers/media/v4l2-core/v4l2-mem2mem.c:629:36: error: 'struct v4l2_m2m_dev' has no member named 'proc'
     media_entity_remove_links(&m2m_dev->proc);
                                       ^~
   drivers/media/v4l2-core/v4l2-mem2mem.c:630:40: error: 'struct v4l2_m2m_dev' has no member named 'source'
     media_device_unregister_entity(m2m_dev->source);
                                           ^~
   drivers/media/v4l2-core/v4l2-mem2mem.c:631:41: error: 'struct v4l2_m2m_dev' has no member named 'sink'
     media_device_unregister_entity(&m2m_dev->sink);
                                            ^~
   drivers/media/v4l2-core/v4l2-mem2mem.c:632:41: error: 'struct v4l2_m2m_dev' has no member named 'proc'
     media_device_unregister_entity(&m2m_dev->proc);
                                            ^~

vim +624 drivers/media/v4l2-core/v4l2-mem2mem.c

   621	
   622	void v4l2_m2m_unregister_media_controller(struct v4l2_m2m_dev *m2m_dev)
   623	{
 > 624		media_remove_intf_links(&m2m_dev->intf_devnode->intf);
 > 625		media_devnode_remove(m2m_dev->intf_devnode);
   626	
 > 627		media_entity_remove_links(m2m_dev->source);
 > 628		media_entity_remove_links(&m2m_dev->sink);
 > 629		media_entity_remove_links(&m2m_dev->proc);
   630		media_device_unregister_entity(m2m_dev->source);
   631		media_device_unregister_entity(&m2m_dev->sink);
   632		media_device_unregister_entity(&m2m_dev->proc);
   633	}
   634	EXPORT_SYMBOL_GPL(v4l2_m2m_unregister_media_controller);
   635	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux