Em Tue, 1 Dec 2009 20:21:52 -0600 (CST) Mike Isely <isely@xxxxxxxxx> escreveu: > On Tue, 1 Dec 2009, Mauro Carvalho Chehab wrote: > > > Mike Isely wrote: > > > On Mon, 30 Nov 2009, Mauro Carvalho Chehab wrote: > > > > > >> Em Sat, 28 Nov 2009 14:33:30 -0600 (CST) > > >> Mike Isely <isely@xxxxxxxxx> escreveu: > > >> > > >>> Mauro: > > >>> > > >>> I had also posted up two high priority pvrusb2 patches that should > > >>> really be cherry-picked for 2.6.32. You've already pulled them into > > >>> v4l/dvb and I did mark them as high priority at the time. > > >>> > > >>> These patches enable use of FX2 microcontroller firmware that is 16KB in > > >>> size. Hauppauge is no longer shipping 8KB firmware for HVR-1950 and > > >>> HVR-1900 and without these changes then those devices won't work AT ALL > > >>> in kernel 2.6.32. > > >>> > > >>> You can find these within the v4l-dvb Mercurial repository here: > > >>> > > >>> Changeset 13495:87c3853fe2b3 > > >>> Subject: pvrusb2: Support 16KB FX2 firmware > > >>> http://linuxtv.org/hg/v4l-dvb/rev/87c3853fe2b3 > > >>> > > >>> Changeset 13500:d4c418d4b25c > > >>> Subject: pvrusb2: Fix lingering 16KB FX2 Firmware issues > > >>> http://linuxtv.org/hg/v4l-dvb/rev/d4c418d4b25c > > >>> > > >>> I do not believe these patches have any ordering dependencies with other > > >>> patches, though between the two the second one technically should come > > >>> after the first. > > > > > > > > > > > >> There are. Picking just those patches broke compilation. > > > > > > Mauro: > > > > > > Please forward to me the compilation errors. Right now I am just not > > > seeing how a patch this trivial could have any compilation dependencies. > > > And unfortunately I will not be able to reproduce your build setup until > > > at least Tuesday night. I must be blind. > > > > > > > > >> Also, it seemed too late for adding support for newer boards/firmware when Linus > > >> is about to release a kernel. > > > > > > This is not a new feature. It's a bug fix due to something that > > > Hauppauge recently did. Hauppauge is NO LONGER officially distributing > > > FX2 firmware with their hardware which the driver can use. This simply > > > prevents any new HVR-1950 / HVR-1900 users from working under Linux. > > > This fixes breakage for previously working hardware. The root cause is > > > simple - the firmware blob is just larger now - and the fix is trivial. > > > It absolutely needs to go in. In fact, this should go back to a > > > 2.6.31.x and a 2.6.27.x release as well, though in those cases I have to > > > figure out if driver source code is still close enough for the same > > > patches to still work. > > > > > > I am sorry this is showing up late for you. There are multiple reasons > > > for this. However I did mark these patches as "high priority", > > > following your v4l-dvb changeset process. I did comment on the pull > > > request that these were important but I guess I needed to also > > > specifically call these out in the pull request text as well. > > > > > > If these don't get in now as part of the official 2.6.32 release, these > > > absolutely need to be queued for 2.6.32.1. > > > > We are very late for 2.6.32. I'm not sure if are there still time for it. > > > > I'll seek for some time during this week to add those patches at the upstream > > tree and removing them from the development tree and see what compilation > > issues arise. > > Mauro: > > Thanks. > > Guess I also really need to get up to speed on git, finally... Hi Mike, Unfortunately, 2.6.32 were launched before we had time to rework on it, so, it needs to be submitted for 2.6.32.1. The requisite for a patch to go to stable just happened: the patch needs to be upstream before going to stable. As Linus already merged our changesets, now it is just a matter of sending an email to stable@xxxxxxxxxx, with the patches. As I've explained before, the patches apply on the trees, but compilation were broken if the order of the changesets changed. I'm not sure if it broke happened at upstream+patches or at the devel tree. So, before submitting the patches, I suggest that you test them against a vanilla 2.6.32. Please c/c on the email to stable. Generally, Mkrufky helps us with stable submissions, but, as I'm not seeing him lately on IRC, maybe he is traveling or too busy those days. Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
