Re: [PATCH/RFC 2/2] arm64: dts: renesas: salvator-common: Fix adv7482 decimal unit addresses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

On 14/06/18 14:48, Geert Uytterhoeven wrote:
With recent dtc and W=1:

     ...salvator-x.dtb: Warning (graph_port): /soc/i2c@e66d8000/video-receiver@70/port@10: graph node unit address error, expected "a"
     ...salvator-x.dtb: Warning (graph_port): /soc/i2c@e66d8000/video-receiver@70/port@11: graph node unit address error, expected "b"

Unit addresses are always hexadecimal (without prefix), while the bases
of reg property values depend on their prefixes.

Fixes: 908001d778eba06e ("arm64: dts: renesas: salvator-common: Add ADV7482 support")
Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
---
  arch/arm64/boot/dts/renesas/salvator-common.dtsi | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
index 320250d708c3bbab..47088206cc052a15 100644
--- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
@@ -437,7 +437,7 @@
  			};
  		};
- port@10 {
+		port@a {
  			reg = <10>;

This looks a bit ugly with the different mappings;
If we must move to 'port@a', I think reg needs to be <0xa>, to avoid confusion. (but I personally prefer port@10, reg = <10> here)


--
Kieran


adv7482_txa: endpoint {
@@ -447,7 +447,7 @@
  			};
  		};
- port@11 {
+		port@b {
  			reg = <11>;
adv7482_txb: endpoint {





[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux