Hello, On Tuesday, 12 June 2018 18:45:53 EEST Sakari Ailus wrote: > On Tue, Jun 12, 2018 at 04:26:06PM +0200, Jacopo Mondi wrote: > > Add a note to the R-Car VIN interface bindings to clarify that all > > properties listed as generic properties in video-interfaces.txt can > > be included in port@0 endpoint, but if not explicitly listed in the > > interface bindings documentation, they do not modify it behaviour. > > > > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> > > --- > > > > Documentation/devicetree/bindings/media/rcar_vin.txt | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt > > b/Documentation/devicetree/bindings/media/rcar_vin.txt index > > 8130849..03544c7 100644 > > --- a/Documentation/devicetree/bindings/media/rcar_vin.txt > > +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt > > @@ -55,6 +55,12 @@ from local SoC CSI-2 receivers (port1) depending on > > SoC. > > > > instances that are connected to external pins should have port 0. > > > > - Optional properties for endpoint nodes of port@0: > > + > > + All properties described in [1] and which apply to the selected > > + media bus type could be optionally listed here to better describe > > + the current hardware configuration, but only the following ones > > do > > + actually modify the VIN interface behaviour: > > + > > I don't think this should be needed. You should only have properties that > describe the hardware configuration in a given system. I agree. Please list explicitly all properties that are applicable for this device, and don't tell which one(s) are used by the driver. > > - hsync-active: see [1] for description. Default is active high. > > - vsync-active: see [1] for description. Default is active high. > > - data-enable-active: polarity of CLKENB signal, see [1] for -- Regards, Laurent Pinchart
