Re: [PATCH 0/2] rockchip/rga: A fix and a cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ezequiel,

> Ccing Jacob at the right address.Ccing Jacob at the right address.
> 
> Perhaps we should fix the MAINTAINERS file.
> 
> On Fri, 2018-06-01 at 16:49 -0300, Ezequiel Garcia wrote:
> > Decided to test v4l2transform filters and found these two
> > issues.
> > 
> > Without the first commit, start_streaming fails. The second
> > commit is just a cleanup, removing a seemingly redundant
> > operation.
> > 
> > Tested on RK3288 Radxa Rock2 with these kind of pipelines:
> > 
> > gst-launch-1.0 videotestsrc ! video/x-
> > raw,width=640,height=480,framerate=30/1,format=RGB !
> > v4l2video0convert ! video/x-
> > raw,width=1920,height=1080,framerate=30/1,format=NV16 ! fakesink
> > 
> > gst-launch-1.0 v4l2src device=/dev/video1 ! video/x-
> > raw,width=640,height=480,framerate=30/1,format=RGB !
> > v4l2video0convert ! video/x-
> > raw,width=1920,height=1080,framerate=30/1,format=NV16 ! kmssink
> > 
> > Ezequiel Garcia (2):
> >   rockchip/rga: Fix broken .start_streaming
> >   rockchip/rga: Remove unrequired wait in .job_abort
> > 
> >  drivers/media/platform/rockchip/rga/rga-buf.c | 44 +++++++++------
> > ----
> >  drivers/media/platform/rockchip/rga/rga.c     | 13 +-----
> >  drivers/media/platform/rockchip/rga/rga.h     |  2 -
> >  3 files changed, 23 insertions(+), 36 deletions(-)
> > 

To both patches,
Reviewed-by: Jacob Chen<jacob-chen@xxxxxxxxxx>

It seems the current job_abort will also cause unnecessary wait when using multi-instance.




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux