Re: [PATCH] media: i2c: adv748x: csi2: set entity function to video interface bridge

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Steve,

On 08/06/18 22:34, Steve Longerbeam wrote:
> Hi Kieran,
> 
> 
> On 06/08/2018 02:29 PM, Kieran Bingham wrote:
>> Hi Steve,
>>
>> Thankyou for the patch.
>>
>> On 08/06/18 18:43, Steve Longerbeam wrote:
>>> The ADV748x CSI-2 subdevices are HMDI/AFE to MIPI CSI-2 bridges.
>>>
>> Reading the documentation for MEDIA_ENT_F_VID_IF_BRIDGE, this seems reasonable.
>>
>> Out of interest, have you stumbled across this as part of your other work on
>> CSI2 drivers - or have you been looking to test the ADV748x with your CSI2
>> receiver? I'd love to know if the driver works with other (non-renesas)
>> platforms!
> 
> This isn't really related to my other work on the i.MX CSI2 receiver driver
> in imx-media. I've only tested this on Renesas (Salvator-X).

No problem. I was just curious :D
And this will get rid of that annoying warning message that I've been ignoring!

Regards

Kieran

> 
> Steve
> 
>>> Signed-off-by: Steve Longerbeam <steve_longerbeam@xxxxxxxxxx>
>> Acked-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
>>
>>
>>> ---
>>>   drivers/media/i2c/adv748x/adv748x-csi2.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/media/i2c/adv748x/adv748x-csi2.c
>>> b/drivers/media/i2c/adv748x/adv748x-csi2.c
>>> index 820b44e..469be87 100644
>>> --- a/drivers/media/i2c/adv748x/adv748x-csi2.c
>>> +++ b/drivers/media/i2c/adv748x/adv748x-csi2.c
>>> @@ -284,7 +284,7 @@ int adv748x_csi2_init(struct adv748x_state *state, struct
>>> adv748x_csi2 *tx)
>>>       adv748x_csi2_set_virtual_channel(tx, 0);
>>>         adv748x_subdev_init(&tx->sd, state, &adv748x_csi2_ops,
>>> -                MEDIA_ENT_F_UNKNOWN,
>>> +                MEDIA_ENT_F_VID_IF_BRIDGE,
>>>                   is_txa(tx) ? "txa" : "txb");
>>>         /* Ensure that matching is based upon the endpoint fwnodes */
>>>
> 

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux