On 06/07/2018 08:14 PM, Y Song wrote:
> On Wed, Jun 6, 2018 at 2:09 PM, Sean Young <sean@xxxxxxxx> wrote:
>> Compile bpf_prog_{attach,detach,query} even if CONFIG_BPF_CGROUP is not
>> set.
>
> It should be CONFIG_CGROUP_BPF here. The same for subject line.
> Today, if CONFIG_CGROUP_BPF is not defined. Users will get an -EINVAL
> if they try to attach/detach/query.
>
> I am not sure what is the motivation behind this change. Could you explain more?
Motivation was that lirc2 progs are not related to cgroups at all and there
are users that have compiled it out, yet it uses BPF_PROG_ATTACH/DETACH for
managing them. This definitely needs to be more clearly explained in the
changelog, agree.
>> Signed-off-by: Sean Young <sean@xxxxxxxx>
>> ---
>> include/linux/bpf-cgroup.h | 31 +++++++++++
>> kernel/bpf/cgroup.c | 110 +++++++++++++++++++++++++++++++++++++
>> kernel/bpf/syscall.c | 105 ++---------------------------------
>> 3 files changed, 145 insertions(+), 101 deletions(-)
>>[...]
