Hi Sergei, On 06/06/18 10:08, Sergei Shtylyov wrote: > Hello! > > On 6/6/2018 2:34 AM, Kieran Bingham wrote: > >> Provide device tree binding documentation for the RDACM GMSL Camera. >> >> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> >> --- >> .../devicetree/bindings/media/i2c/rdacm20.txt | 31 +++++++++++++++++++ >> .../devicetree/bindings/vendor-prefixes.txt | 1 + >> 2 files changed, 32 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/media/i2c/rdacm20.txt >> >> diff --git a/Documentation/devicetree/bindings/media/i2c/rdacm20.txt >> b/Documentation/devicetree/bindings/media/i2c/rdacm20.txt >> new file mode 100644 >> index 000000000000..22898e835580 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/i2c/rdacm20.txt >> @@ -0,0 +1,31 @@ >> +* Global IMI RDACM20 GMSL Camera >> + >> +Required Properties: >> + - compatible: shall be "imi,rdacm20" >> + - reg: MAX9271 and OV10635 I2C addresses >> + >> +The camera node shall be connected to an I2C bus interface of >> +the GMSL deserialiser device of which will receive image data. >> + >> +The device node shall contain one 'port' child node with an >> +'endpoint' subnode for its digital output video port, >> +in accordance with the video interface bindings defined in >> +Documentation/devicetree/bindings/media/video-interfaces.txt. >> + >> +Example: >> + >> +i2c@0 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + reg = <0>; >> + camera@51 { >> + compatible = MAXIM_CAMERA0; > > What? Argh - that's my 'magic defines' higher in the DTB, which I forgot to fixup :D (/me should not write patches at midnight.. :D) I believe Jacopo has a better version of this binding on it's way. As I appear to have duplicated his work. I'll likely drop my binding documentation and use his. Sorry for the noise. >> + reg = <0x51 0x61>; >> + >> + port { >> + rdacm20_out0: endpoint { >> + remote-endpoint = <&max9286_in0>; >> + }; >> + }; >> + }; >> +}; >> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt >> b/Documentation/devicetree/bindings/vendor-prefixes.txt >> index b5f978a4cac6..1e438341ea6b 100644 >> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt >> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt >> @@ -160,6 +160,7 @@ idt Integrated Device Technologies, Inc. >> ifi Ingenieurburo Fur Ic-Technologie (I/F/I) >> ilitek ILI Technology Corporation (ILITEK) >> img Imagination Technologies Ltd. >> +imi Integrated Micro-Electronics Inc. >> infineon Infineon Technologies >> inforce Inforce Computing >> ingenic Ingenic Semiconductor > > I think this update needs to be in a separate patch. Ok, I'll split this out. Regards Kieran