On 02-06-18, 01:15, Stanimir Varbanov wrote: > Hi Vikash, > > On 1.06.2018 23:26, Vikash Garodia wrote: > > Add a new routine to reset the ARM9 and brings it > > out of reset. This is in preparation to add PIL > > functionality in venus driver. > > please squash this patch with 4/5. I don't see a reason to add a function > which is not used. Shouldn't this produce gcc warnings? Yes this would but in a multi patch series that is okay as subsequent patches would use that and end result in no warning. Splitting logically is good and typical practice in kernel to add the routine followed by usages.. -- ~Vinod
