Re: [PATCH v2 4/4] ARM: dts: rcar-gen2: Remove unused VIN properties

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 04, 2018 at 01:31:54PM +0200, Niklas Söderlund wrote:
> Hi Simon,
> 
> On 2018-06-04 11:53:09 +0200, Simon Horman wrote:
> > On Mon, May 21, 2018 at 07:27:43PM +0200, Jacopo Mondi wrote:
> > 
> > > The 'bus-width' and 'pclk-sample' properties are not parsed by the VIN
> > > driver and only confuse users. Remove them in all Gen2 SoC that use
> > > them.
> > 
> > I think that the rational for removing properties (or not) is their
> > presence in the bindings as DT should describe the hardware and not the
> > current state of the driver implementation.
> > 
> > I see that 'bus-width' may be removed from the binding, as per discussion
> > in a different sub-thread. I'd like that discussion to reach a conclusion
> > before considering that part of this patch any further.
> > 
> > And I'd appreciate Niklas's feedback on the 'pclk-sample' portion.
> 
> My thoughts on 'pclk-sample' is the same as for 'bus-width', they 
> describe the hardware. So we either should keep or remove both. As our 
> discussion in the other thread I'm leaning towards that both should be 
> kept.

Thanks, that sounds reasonable to me.

I'm marking (v4 of) this as deferred pending a conclusion to that
conversation.




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux