Hi Tomasz, Thanks for the review! On 05/31/2018 10:59 AM, Tomasz Figa wrote: > On Tue, May 15, 2018 at 5:06 PM Stanimir Varbanov > <stanimir.varbanov@xxxxxxxxxx> wrote: >> >> Rename is_reg_unreg_needed() to better name is_dynamic_bufmode() and >> use buffer mode from enumerated per codec capabilities. >> >> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@xxxxxxxxxx> >> --- >> drivers/media/platform/qcom/venus/helpers.c | 21 +++++++++++---------- >> 1 file changed, 11 insertions(+), 10 deletions(-) >> >> diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c >> index 2b21f6ed7502..1eda19adbf28 100644 >> --- a/drivers/media/platform/qcom/venus/helpers.c >> +++ b/drivers/media/platform/qcom/venus/helpers.c >> @@ -354,18 +354,19 @@ session_process_buf(struct venus_inst *inst, struct vb2_v4l2_buffer *vbuf) >> return 0; >> } >> >> -static inline int is_reg_unreg_needed(struct venus_inst *inst) >> +static inline int is_dynamic_bufmode(struct venus_inst *inst) > > nit: Could be made bool. And drop inline I guess? :) -- regards, Stan
