Hello! On 05/30/2018 12:13 PM, Jacopo Mondi wrote: > The TW9910 PDN gpio (power down) is listed as active high in the chip GPIO. > manual. It turns out it is actually active low as when set to physical > level 0 it actually turns the video decoder power off. > > Without this patch applied: > tw9910 0-0045: Product ID error 1f:2 > > With this patch applied: > tw9910 0-0045: tw9910 Product ID b:0 > > Fixes: commit "186c446f4b840bd77b79d3dc951ca436cb8abe79" That's not how you specify the "Fixes:" tag, please see Documentation/process/submitting-patches.rst. > There shouldn't be an emoty line here. > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> [...] MBR, Sergei