Hi Mauro, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.17-rc7 next-20180529] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/media-dvb-get-rid-of-VIDEO_SET_SPU_PALETTE/20180530-033705 config: mips-fuloong2e_defconfig (attached as .config) compiler: mips64el-linux-gnuabi64-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=mips All warnings (new ones prefixed by >>): fs/compat_ioctl.c: In function 'do_video_set_spu_palette': fs/compat_ioctl.c:220:45: error: invalid application of 'sizeof' to incomplete type 'struct video_spu_palette' up_native = compat_alloc_user_space(sizeof(struct video_spu_palette)); ^~~~~~ In file included from include/linux/uaccess.h:14:0, from include/linux/compat.h:20, from fs/compat_ioctl.c:17: fs/compat_ioctl.c:221:46: error: dereferencing pointer to incomplete type 'struct video_spu_palette' err = put_user(compat_ptr(palp), &up_native->palette); ^ arch/mips/include/asm/uaccess.h:444:15: note: in definition of macro '__put_user_check' __typeof__(*(ptr)) __user *__pu_addr = (ptr); \ ^~~ fs/compat_ioctl.c:221:9: note: in expansion of macro 'put_user' err = put_user(compat_ptr(palp), &up_native->palette); ^~~~~~~~ >> arch/mips/include/asm/uaccess.h:445:32: warning: initialization makes integer from pointer without a cast [-Wint-conversion] __typeof__(*(ptr)) __pu_val = (x); \ ^ >> arch/mips/include/asm/uaccess.h:158:2: note: in expansion of macro '__put_user_check' __put_user_check((x), (ptr), sizeof(*(ptr))) ^~~~~~~~~~~~~~~~ fs/compat_ioctl.c:221:9: note: in expansion of macro 'put_user' err = put_user(compat_ptr(palp), &up_native->palette); ^~~~~~~~ At top level: fs/compat_ioctl.c:208:12: warning: 'do_video_set_spu_palette' defined but not used [-Wunused-function] static int do_video_set_spu_palette(struct file *file, ^~~~~~~~~~~~~~~~~~~~~~~~ vim +445 arch/mips/include/asm/uaccess.h ^1da177e include/asm-mips/uaccess.h Linus Torvalds 2005-04-16 441 ^1da177e include/asm-mips/uaccess.h Linus Torvalds 2005-04-16 442 #define __put_user_check(x, ptr, size) \ ^1da177e include/asm-mips/uaccess.h Linus Torvalds 2005-04-16 443 ({ \ fe00f943 include/asm-mips/uaccess.h Ralf Baechle 2005-03-01 @444 __typeof__(*(ptr)) __user *__pu_addr = (ptr); \ fe00f943 include/asm-mips/uaccess.h Ralf Baechle 2005-03-01 @445 __typeof__(*(ptr)) __pu_val = (x); \ 8d2d91e8 include/asm-mips/uaccess.h Ralf Baechle 2008-10-11 446 int __pu_err = -EFAULT; \ ^1da177e include/asm-mips/uaccess.h Linus Torvalds 2005-04-16 447 \ ef41f460 arch/mips/include/asm/uaccess.h Ralf Baechle 2009-04-28 448 might_fault(); \ ac1d8590 arch/mips/include/asm/uaccess.h Markos Chandras 2013-12-11 449 if (likely(access_ok(VERIFY_WRITE, __pu_addr, size))) { \ 12060666 arch/mips/include/asm/uaccess.h Paul Burton 2015-05-24 450 if (eva_kernel_access()) \ ac1d8590 arch/mips/include/asm/uaccess.h Markos Chandras 2013-12-11 451 __put_kernel_common(__pu_addr, size); \ ac1d8590 arch/mips/include/asm/uaccess.h Markos Chandras 2013-12-11 452 else \ ec56b1d4 arch/mips/include/asm/uaccess.h Markos Chandras 2013-12-17 453 __put_user_common(__pu_addr, size); \ ac1d8590 arch/mips/include/asm/uaccess.h Markos Chandras 2013-12-11 454 } \ ec56b1d4 arch/mips/include/asm/uaccess.h Markos Chandras 2013-12-17 455 \ ^1da177e include/asm-mips/uaccess.h Linus Torvalds 2005-04-16 456 __pu_err; \ ^1da177e include/asm-mips/uaccess.h Linus Torvalds 2005-04-16 457 }) ^1da177e include/asm-mips/uaccess.h Linus Torvalds 2005-04-16 458 :::::: The code at line 445 was first introduced by commit :::::: fe00f943e0ef98b4057abcc2940d631a975b43cd Sparseify MIPS. :::::: TO: Ralf Baechle <ralf@xxxxxxxxxxxxxx> :::::: CC: Ralf Baechle <ralf@xxxxxxxxxxxxxx> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
