Re: [PATCH v3] Add udmabuf misc device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v3] Add udmabuf misc device
From: Oleksandr Andrushchenko <andr2000@xxxxxxxxx>
Date: Tue, 29 May 2018 14:07:31 +0300
Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx, Tomeu Vizoso <tomeu.vizoso@xxxxxxxxxxxxx>, David Airlie <airlied@xxxxxxxx>, open list <linux-kernel@xxxxxxxxxxxxxxx>, "moderated list:DMA BUFFER SHARING FRAMEWORK" <linaro-mm-sig@xxxxxxxxxxxxxxxx>, "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@xxxxxxxxxxxxxxx>, Shuah Khan <shuah@xxxxxxxxxx>, "open list:DMA BUFFER SHARING FRAMEWORK" <linux-media@xxxxxxxxxxxxxxx>
In-reply-to: <20180529105037.uog4tvcckqp5q6fe@sirius.home.kraxel.org>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0

On 05/29/2018 01:50 PM, Gerd Hoffmann wrote:

Hi,

+config UDMABUF
+	bool "userspace dmabuf misc driver"
+	default n
+	depends on DMA_SHARED_BUFFER

Don't you want "select DMA_SHARED_BUFFER" here instead?

Why do you think so?

After thinking a bit more your code looks ok,
sorry for the noise

cheers,
   Gerd

References:
- [PATCH v3] Add udmabuf misc device
  - From: Gerd Hoffmann
- Re: [PATCH v3] Add udmabuf misc device
  - From: Oleksandr Andrushchenko
- Re: [PATCH v3] Add udmabuf misc device
  - From: Gerd Hoffmann

Prev by Date: Re: [PATCH v3] Add udmabuf misc device
Next by Date: [ragnatech:media-tree 442/456] drivers/media/usb/pvrusb2/pvrusb2-v4l2.o: warning: objtool: pvr2_v4l2_dev_init.cold.3()+0x4a: return with modified stack frame
Previous by thread: Re: [PATCH v3] Add udmabuf misc device
Next by thread: [PATCH] udmabuf: fix odd_ptr_err.cocci warnings
Index(es):
- Date
- Thread

[Index of Archives] [Linux Input] [Video for Linux] [Gstreamer Embedded] [Mplayer Users] [Linux USB Devel] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Yosemite Backpacking]

Powered by Linux