Hi Jacopo, Thanks for your patch. On 2018-05-21 19:27:41 +0200, Jacopo Mondi wrote: > Document 'data-active' property in R-Car VIN device tree bindings. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> > > v1 -> v2: > - HSYNC is used in place of data enable signal only when running with > explicit synchronizations. > - The property is no more mandatory when running with embedded > synchronizations, and default is selected. > --- > Documentation/devicetree/bindings/media/rcar_vin.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt > index dab3118..2c144b4 100644 > --- a/Documentation/devicetree/bindings/media/rcar_vin.txt > +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt > @@ -64,6 +64,12 @@ from local SoC CSI-2 receivers (port1) depending on SoC. > If both HSYNC and VSYNC polarities are not specified, embedded > synchronization is selected. > > + - data-active: data enable signal line polarity (CLKENB pin). > + 0/1 for LOW/HIGH respectively. If not specified and running with > + embedded synchronization, the default is active high. If not > + specified and running with explicit synchronization, HSYNC is used > + as data enable signal. This indentation looks funny :-) If you check the rest of the rcar_vin.txt file only spaces are used for indentation. > + > - port 1 - sub-nodes describing one or more endpoints connected to > the VIN from local SoC CSI-2 receivers. The endpoint numbers must > use the following schema. > -- > 2.7.4 > -- Regards, Niklas Söderlund