On Mon, May 21, 2018 at 04:54:07PM +0100, Sean Young wrote:
> On Mon, May 21, 2018 at 04:38:01PM +0200, Michał Winiarski wrote:
> > It appears that we need to enable CIR device before attempting to touch
> > some of the registers. Previously, this was not a big issue, since we
> > were rarely seeing nvt_close() getting called.
> >
> > Unfortunately, since:
> > cb84343fced1 ("media: lirc: do not call close() or open() on unregistered devices")
> >
> > The initial open() during probe from rc_setup_rx_device() is no longer
> > successful, which means that userspace clients will actually end up
> > calling nvt_open()/nvt_close().
> > And since nvt_open() is broken, the device doesn't seem to work as
> > expected.
>
> Since that commit was in v4.16, should we have the following:
>
> Cc: stable@xxxxxxxxxxxxxxx # v4.16+
>
> On this commit (and not the other two, if I understand them correctly)?
Correct. I even had it in the series attached to the bugzilla.
Dropped it because the bug reporters have not confirmed that it fixes their
problem yet. (works for me though...)
-Michał
>
> Thanks,
> Sean
>
> >
> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=199597
> > Signed-off-by: Michał Winiarski <michal.winiarski@xxxxxxxxx>
> > Cc: Jarod Wilson <jarod@xxxxxxxxxx>
> > Cc: Sean Young <sean@xxxxxxxx>
> > ---
> > drivers/media/rc/nuvoton-cir.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
