On Tue, May 15, 2018 at 5:12 PM Stanimir Varbanov < stanimir.varbanov@xxxxxxxxxx> wrote: > Add AXI halt support for version 4xx by using venus wrapper > registers. > Signed-off-by: Stanimir Varbanov <stanimir.varbanov@xxxxxxxxxx> > --- > drivers/media/platform/qcom/venus/hfi_venus.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > diff --git a/drivers/media/platform/qcom/venus/hfi_venus.c b/drivers/media/platform/qcom/venus/hfi_venus.c > index 734ce11b0ed0..53546174aab8 100644 > --- a/drivers/media/platform/qcom/venus/hfi_venus.c > +++ b/drivers/media/platform/qcom/venus/hfi_venus.c > @@ -532,6 +532,23 @@ static int venus_halt_axi(struct venus_hfi_device *hdev) > u32 val; > int ret; > + if (hdev->core->res->hfi_version == HFI_VERSION_4XX) { > + val = venus_readl(hdev, WRAPPER_CPU_AXI_HALT); > + val |= BIT(16); Can we have the bit defined? > + venus_writel(hdev, WRAPPER_CPU_AXI_HALT, val); > + > + ret = readl_poll_timeout(base + WRAPPER_CPU_AXI_HALT_STATUS, > + val, val & BIT(24), Ditto. Best regards, Tomasz