2018-05-17 22:01 UTC+0100 ~ Sean Young <sean@xxxxxxxx> > On Thu, May 17, 2018 at 10:17:59AM -0700, Y Song wrote: >> On Wed, May 16, 2018 at 2:04 PM, Sean Young <sean@xxxxxxxx> wrote: >>> This is simple test over rc-loopback. >>> >>> Signed-off-by: Sean Young <sean@xxxxxxxx> >>> --- >>> tools/bpf/bpftool/prog.c | 1 + >>> tools/include/uapi/linux/bpf.h | 57 +++++++- >>> tools/lib/bpf/libbpf.c | 1 + >>> tools/testing/selftests/bpf/Makefile | 8 +- >>> tools/testing/selftests/bpf/bpf_helpers.h | 6 + >>> tools/testing/selftests/bpf/test_rawir.sh | 37 +++++ >>> .../selftests/bpf/test_rawir_event_kern.c | 26 ++++ >>> .../selftests/bpf/test_rawir_event_user.c | 130 ++++++++++++++++++ >>> 8 files changed, 261 insertions(+), 5 deletions(-) >>> create mode 100755 tools/testing/selftests/bpf/test_rawir.sh >>> create mode 100644 tools/testing/selftests/bpf/test_rawir_event_kern.c >>> create mode 100644 tools/testing/selftests/bpf/test_rawir_event_user.c [...] >> Most people probably not really familiar with lircN device. It would be >> good to provide more information about how to enable this, e.g., >> CONFIG_RC_CORE=y >> CONFIG_BPF_RAWIR_EVENT=y >> CONFIG_RC_LOOPBACK=y >> ...... > > Good point. I'll add some words explaining what is and how to make it work. > > Thanks > Sean By the way, shouldn't the two eBPF helpers bpf_rc_keydown() and bpf_rc_repeat() be compiled out in patch 1 if e.g. CONFIG_BPF_RAWIR_EVENT is not set? There are some other helpers that are compiled only if relevant config options are set (bpf_get_xfrm_state() for example). (If you were to change that, please also update helper documentations to indicate what configuration options are required to be able to use the helpers.) Best regards, Quentin
