On Wed, May 09, 2018 at 11:31:30PM +0300, Sakari Ailus wrote: > The clocks enabled by csi2rx_start function are intended to be disabled in > an error path but there are two issues: > > 1) the loop condition is always true and > > 2) the first clock disabled is the the one enabling of which failed. > > Fix these two bugs by changing the loop condition as well as only disabling > the clocks that were actually enabled. > > Reported-by: Mauro Chehab <mchehab@xxxxxxxxxx> > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > --- > Hi Mauro, Maxime, > > Let me know if you're happy with this. It's intended to fix the following > warnings (C=1 W=1): > > drivers/media/platform/cadence/cdns-csi2rx.c: In function ‘csi2rx_start’: > drivers/media/platform/cadence/cdns-csi2rx.c:177:11: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] > > drivers/media/platform/cadence/cdns-csi2rx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) That works for me :) Feel free to add my Acked-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxx> Thanks! Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
Attachment:
signature.asc
Description: PGP signature
