[PATCH 0/2] rcar-vin: Fix potential buffer overrun root cause

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Commit 015060cb7795eac3 ("media: rcar-vin: enable field toggle after a 
set number of lines for Gen3") was an attempt to fix the issue of 
writing outside the capture buffer for VIN Gen3. Unfortunately it only 
fixed a symptom of a problem to such a degree I could no longer 
reproduce it.

Jacopo on the other hand working on a different setup still ran into the 
issue. And he even figured out the root cause of the issue. When I 
submitted the original VIN Gen3 support I had when addressing a review 
comment missed to keep the crop and compose dimensions in sync with the 
requested format resulting in the DMA engine not properly stopping 
before writing outside the buffer.

This series reverts the incorrect fix in 1/2 and applies a correct one 
in 2/2. I think this should be picked up for v4.18.

Niklas Söderlund (2):
  Revert "media: rcar-vin: enable field toggle after a set number of
    lines for Gen3"
  rcar-vin: fix crop and compose handling for Gen3

 drivers/media/platform/rcar-vin/rcar-dma.c  | 20 +++++---------------
 drivers/media/platform/rcar-vin/rcar-v4l2.c |  6 ++++++
 2 files changed, 11 insertions(+), 15 deletions(-)

-- 
2.17.0




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux