Hi Jason, On Wed, May 09, 2018 at 09:28:30AM +0000, Chen, JasonX Z wrote: > Hello Tomasz > > >> +/* Test Pattern Control */ > >> +#define IMX258_REG_TEST_PATTERN 0x0600 > >> +#define IMX258_TEST_PATTERN_DISABLE 0 > >> +#define IMX258_TEST_PATTERN_SOLID_COLOR 1 > >> +#define IMX258_TEST_PATTERN_COLOR_BARS 2 #define > >> +IMX258_TEST_PATTERN_GREY_COLOR 3 > >> +#define IMX258_TEST_PATTERN_PN9 4 > >> + > >> +/* Orientation */ > >> +#define REG_MIRROR_FLIP_CONTROL 0x0101 > >> +#define REG_CONFIG_MIRROR_FLIP 0x03 > >> +#define REG_CONFIG_FLIP_TEST_PATTERN 0x02 > > > >The names are inconsistent here. All other register addresses start with IMX258_REG and values with IMX258_<field name> (no REG). > > > >[snip] > > We will update at next patch. Just to clarify: please send a patch on top of the earlier revision to address the comments. A pull request containing it has already been sent: <URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=for-4.18-3> Thanks. -- Kind regards, Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxx
