On Fri, May 04, 2018 at 03:43:07PM +0300, Sakari Ailus wrote: > > diff --git a/include/media/media-request.h b/include/media/media-request.h > > index 997e096d7128..5367b4a2f91c 100644 > > --- a/include/media/media-request.h > > +++ b/include/media/media-request.h > > @@ -196,6 +196,22 @@ static inline void media_request_object_get(struct media_request_object *obj) > > */ > > void media_request_object_put(struct media_request_object *obj); > > > > +/** > > + * media_request_object_find - Find an object in a request > > + * > > + * @ops: Find an object with this ops value > > + * @priv: Find an object with this priv value > > + * > > + * Both @ops and @priv must be non-NULL. > > + * > > + * Returns NULL if not found or the object pointer. The caller must > > I'd describe the successful case first. I.e. "Returns the object pointer or > NULL it not found". Oops... "Returns the object pointer or NULL if not found". -- Sakari Ailus e-mail: sakari.ailus@xxxxxx