Re: [PATCH 28/28] venus: add HEVC codec support

[Stanimir Varbanov <stanimir.varbanov@xxxxxxxxxx>]

Hi Hans,

On  7.05.2018 13:39, Hans Verkuil wrote:
> On 24/04/18 14:44, Stanimir Varbanov wrote:
> > This add HEVC codec support for venus versions 3xx and 4xx.
> >
> > Signed-off-by: Stanimir Varbanov <stanimir.varbanov@xxxxxxxxxx>
> > ---
> >   drivers/media/platform/qcom/venus/helpers.c | 3 +++
> >   drivers/media/platform/qcom/venus/hfi.c     | 2 ++
> >   drivers/media/platform/qcom/venus/vdec.c    | 4 ++++
> >   drivers/media/platform/qcom/venus/venc.c    | 4 ++++
> >   4 files changed, 13 insertions(+)
> >
> > diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c
> > index 87dcf9973e6f..fecadba039cf 100644
> > --- a/drivers/media/platform/qcom/venus/helpers.c
> > +++ b/drivers/media/platform/qcom/venus/helpers.c
> > @@ -71,6 +71,9 @@ bool venus_helper_check_codec(struct venus_inst *inst, u32 v4l2_pixfmt)
> >   	case V4L2_PIX_FMT_XVID:
> >   		codec = HFI_VIDEO_CODEC_DIVX;
> >   		break;
> > +	case V4L2_PIX_FMT_HEVC:
> > +		codec = HFI_VIDEO_CODEC_HEVC;
> > +		break;
> >   	default:
> >   		return false;
> >   	}
> > diff --git a/drivers/media/platform/qcom/venus/hfi.c b/drivers/media/platform/qcom/venus/hfi.c
> > index 94ca27b0bb99..24207829982f 100644
> > --- a/drivers/media/platform/qcom/venus/hfi.c
> > +++ b/drivers/media/platform/qcom/venus/hfi.c
> > @@ -49,6 +49,8 @@ static u32 to_codec_type(u32 pixfmt)
> >   		return HFI_VIDEO_CODEC_VP9;
> >   	case V4L2_PIX_FMT_XVID:
> >   		return HFI_VIDEO_CODEC_DIVX;
> > +	case V4L2_PIX_FMT_HEVC:
> > +		return HFI_VIDEO_CODEC_HEVC;
> >   	default:
> >   		return 0;
> >   	}
> > diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c
> > index 7deee104ac56..a114f421edad 100644
> > --- a/drivers/media/platform/qcom/venus/vdec.c
> > +++ b/drivers/media/platform/qcom/venus/vdec.c
> > @@ -77,6 +77,10 @@ static const struct venus_format vdec_formats[] = {
> >   		.pixfmt = V4L2_PIX_FMT_XVID,
> >   		.num_planes = 1,
> >   		.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
> > +	}, {
> > +		.pixfmt = V4L2_PIX_FMT_HEVC,
> > +		.num_planes = 1,
> > +		.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE,
> >   	},
> >   };
> >   
> > diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platform/qcom/venus/venc.c
> > index a703bce78abc..fdb76b69786f 100644
> > --- a/drivers/media/platform/qcom/venus/venc.c
> > +++ b/drivers/media/platform/qcom/venus/venc.c
> > @@ -59,6 +59,10 @@ static const struct venus_format venc_formats[] = {
> >   		.pixfmt = V4L2_PIX_FMT_VP8,
> >   		.num_planes = 1,
> >   		.type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE,
> > +	}, {
> > +		.pixfmt = V4L2_PIX_FMT_HEVC,
> > +		.num_planes = 1,
> > +		.type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE,
> >   	},
> >   };
> >   
>
> No changes are necessary to venc_set_properties() for HEVC support?
>
> Just checking, I kind of expected that.

yes, I think so, but will leave that for future updates.

regards,
Stan