Re: [PATCH 1/2] dt-bindings: media: Add "upside-down" property to tell sensor orientation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sebastian,

On Thu, May 03, 2018 at 05:26:59PM +0200, Sebastian Reichel wrote:
> Hi,
> 
> On Thu, May 03, 2018 at 12:31:14AM +0300, Sakari Ailus wrote:
> > Camera sensors are occasionally mounted upside down. In order to use such
> > a sensor without having to turn every image upside down separately, most
> > camera sensors support reversing the readout order by setting both
> > horizontal and vertical flipping.
> > 
> > This patch adds a boolean property to tell a sensor is mounted upside
> > down.
> > 
> > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> 
> I think the DT binding should use a rotation property instead,
> similar to the panel bindings:
> 
> Documentation/devicetree/bindings/display/panel/panel.txt

Good point. I was trying to find something relevant relating to e.g.
orientation but this one escaped me.

So... I'll abandon this patch, and use the "rotation" property instead.
I'll send v2 of the smiapp patch. I think I'll actually split that into
two, DT and driver changes.

-- 
Kind regards,

Sakari Ailus
sakari.ailus@xxxxxxxxxxxxxxx



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux