RE: [PATCH v0 1/2] V4L - vpfe capture - convert ccdc drivers to platform drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 04, 2009 at 01:21:43, Karicheri, Muralidharan wrote:
>

[...]

> >
> >> +  if (!res) {
> >> +          status = -EBUSY;
> >> +          goto fail_nores;
> >> +  }
> >> +
> >> +  ccdc_base_addr = ioremap_nocache(res->start, res_len);
> >> +  if (!ccdc_base_addr) {
> >> +          status = -EBUSY;
> >[Hiremath, Vaibhav] Is -EBUSY right return value, I think it should be -
> >ENXIO or -ENOMEM.
> >
> I see -ENXIO & -ENOMEM being used by drivers. -ENXIO stands for "No such device or address". ENOMEM stands for "Out of memory" . Since we are trying to map the address here, -ENXIO looks reasonable to me. Same if request_mem_region() fails.
>

Sergei had posted on this earlier[1]. Quoting him here:

"
> What are the proper error codes when platform_get_resource,

    -ENODEV.

> request_mem_region

    -EBUSY.

> and ioremap functions fail?.

    -ENOMEM.
"

Not sure if ioremap failure can relate to absence of a device.

Thanks,
Sekhar

[1] http://www.mail-archive.com/davinci-linux-open-source@xxxxxxxxxxxxxxxxxxxx/msg14973.html

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux